Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Unused Address set in Contacts #649

Open
AlejoLovallo opened this issue Jul 27, 2024 · 0 comments
Open

Bug: Unused Address set in Contacts #649

AlejoLovallo opened this issue Jul 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@AlejoLovallo
Copy link

Describe the bug

In https://github.com/xmtp/xmtp-js/blob/main/packages/js-sdk/src/Contacts.ts#L332 the addresses set is not used at all and thus when retrieving the contacts list you only get an empty set. the

Expected behavior

Update the address set according the consent management behavior.

Steps to reproduce the bug

  /**
   * @dev Get client contacts
   * @returns set of string contacts addresses
   */
  private _getContacts(): Set<string> {
    return this.client.contacts.addresses
  }

Result

      Set(0) {}
@AlejoLovallo AlejoLovallo added the bug Something isn't working label Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant