Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Remove Dependency on Expo Modules #286

Open
4 of 15 tasks
alexrisch opened this issue Feb 23, 2024 · 0 comments
Open
4 of 15 tasks

Feature request: Remove Dependency on Expo Modules #286

alexrisch opened this issue Feb 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@alexrisch
Copy link
Contributor

alexrisch commented Feb 23, 2024

Is your feature request related to a problem?

Expo modules requires some additional setup for installation and requires integrators to potentially need to add a large amount of size to their app.
I don't believe that the SDK has any dependencies on Expo itself other than that the package uses it to make bridging easier

Describe the solution to the problem

Remove expo modules and move to default react native package behavior.
Update example app paths etc.

Describe the uses cases for the feature

This should allow users using React Native CLI to install without the additional expo modules work and should not require additional changes to the expo managed workflow installation process

Additional details

Basic steps forward:

  • Create a new package npx create-react-native-library@latest xmtp
  • Create feature branch in Github
  • Add JS files from current package

Android:

  • add the necessary dependencies from android/build.gradle
  • Update native module names to match the current package
  • Add Native Files from current project except for XmtpModule file this will require further changes
  • Add AsyncFunction handling and verify usage with a single bridged function
  • Add Event handling
  • Full test verification

iOS:

  • add the necessary dependencies from ios/Podspec
  • Update native module names to match the current package
  • Add Native Files from current project except for XmtpModule file this will require further changes
  • Add AsyncFunction handling and verify usage with a single bridged function
  • Add Event handling
  • Full test verification
@alexrisch alexrisch added the enhancement New feature or request label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant