Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to add arguments to protoc #77

Open
xavipen opened this issue Oct 6, 2020 · 1 comment
Open

Allow to add arguments to protoc #77

xavipen opened this issue Oct 6, 2020 · 1 comment

Comments

@xavipen
Copy link

xavipen commented Oct 6, 2020

In protobuffer 3.12.0 it has been added experimental support for optional in proto3.

In order to activate this the following flag should be added to protoc:
--experimental_allow_proto3_optional

I have read the documentation and it seems that it is not possible to pass any additional parameter to protoc using this plugin.

It would be great if it would be possible to add arguments to the protocArtifact to be able to activate experimental supports
melocotton pushed a commit to melocotton/protobuf-maven-plugin that referenced this issue Oct 8, 2020
@sebhvrsg
adding support for experimental_allow_proto3_optional
ef0cb8b 
cf. xolstice#77
@melocotton melocotton mentioned this issue Oct 8, 2020
Open
@melocotton
Copy link

melocotton commented Oct 8, 2020 •
edited
Loading

Hello, I've created a PR to add support of experimental_allow_proto3_optional.

#78

@sebastienvermeille sebastienvermeille mentioned this issue May 5, 2021
Closed
snazy pushed a commit to snazy/protobuf-maven-plugin that referenced this issue Jan 10, 2022
@sebhvrsg @snazy
adding support for experimental_allow_proto3_optional
7d6ef25 
cf. xolstice#77
@sebastienvermeille sebastienvermeille mentioned this issue Aug 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xavipen @melocotton