Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript support #957

Open
kurai-espoir opened this issue Aug 29, 2021 · 5 comments
Open

TypeScript support #957

kurai-espoir opened this issue Aug 29, 2021 · 5 comments

Comments

@kurai-espoir
Copy link

kurai-espoir commented Aug 29, 2021

It would be great if you added support for TypeScript users

EDIT:
I didn't realized there was a types directory. Consider renaming the files from *.js to *.d.ts?

@xtuc
Copy link
Owner

xtuc commented Aug 29, 2021

I believe this types are used by webpack, if we rename the file we need to ensure webpack doesn't break.

Would you mind sending a PR?

@kurai-espoir
Copy link
Author

Sure. I'll send one by this week.

@pcardune
Copy link

I believe the files in the types directory are only for flowtype and will need more than renaming to make them work with typescript. I'm also interested in having typescript type declarations. Let me know if you'd like some help @kurai-espoir

@xtuc
Copy link
Owner

xtuc commented Aug 30, 2021

Long term I think we should remove flow in the repo and replace with typescript.

@gustavohenke
Copy link

Hi @xtuc, how do you see this happening -- by rewriting everything to TS, or by keeping the code as JS + adding TS types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants