Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2FA - Google Authenticator - Enable/disable #110

Open
xy2z opened this issue Sep 20, 2019 · 7 comments
Open

2FA - Google Authenticator - Enable/disable #110

xy2z opened this issue Sep 20, 2019 · 7 comments
Labels
backend enhancement New feature or request help wanted Extra attention is needed

Comments

@xy2z
Copy link
Owner

xy2z commented Sep 20, 2019

https://github.com/antonioribeiro/google2fa-laravel

Under "User settings" it should be possible to enable/disable 2FA using Google Authenticator.
When disabling, user must enter the current 2FA code before succeeding.

Let me know if you have any questions

@xy2z xy2z added help wanted Extra attention is needed hacktoberfest Hacktoberfest 2019 enhancement New feature or request labels Sep 20, 2019
@finalbytes
Copy link

Hey,
I want to see if I can help you to disable the Google Authenticator in the settings page (# 110). Shall I open a PR?

@xy2z
Copy link
Owner Author

xy2z commented Sep 25, 2019

@finalbytes not disable, enable :) yes please

Edit: oh you meant the disable part. The enable part is part of this issue and im not sure it makes sense to split these 2 up?

@xy2z xy2z changed the title 2FA - Google Authenticator 2FA - Google Authenticator - Enable/disable Sep 25, 2019
@xy2z xy2z added the backend label Sep 25, 2019
@finalbytes
Copy link

finalbytes commented Sep 25, 2019

Okay, I think I misunderstood you. But I understand from this that you want to have the 2FA built into your application (dopenote). And if you want to switch it off that you also use the 6-digit code of your 2FA? Do I understand you better? Then it seems useful that I first implement this in the application, and then make the addition for switching off with code. Let me know if you actually mean this.

@xy2z
Copy link
Owner Author

xy2z commented Sep 26, 2019

@finalbytes yes exactly. Per user.

@finalbytes
Copy link

I'll implement this feature for you!

@xy2z
Copy link
Owner Author

xy2z commented Sep 27, 2019

@finalbytes awesome :)

@xy2z
Copy link
Owner Author

xy2z commented Oct 7, 2019

@finalbytes how's it going? 😃

@xy2z xy2z pinned this issue Oct 10, 2019
@xy2z xy2z removed the hacktoberfest Hacktoberfest 2019 label Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants