Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing warnings? #6

Open
richelbilderbeek opened this issue May 16, 2017 · 0 comments
Open

Fixing warnings? #6

richelbilderbeek opened this issue May 16, 2017 · 0 comments

Comments

@richelbilderbeek
Copy link
Contributor

Hi yageek,

When compiling Meschach with high warning levels, I get a lot of those. Especially type conversion warnings. May, should and if yes, how should I fix these?

For example,

unsigned int u = 43;
int i = 24;
if (i == j) {
  /* Do something */
}

Should I make it

  • if ((int) i == j)
  • if (i == (unsigned int) j)
  • leave it as it is: this maybe just common C style

I'd love to help and fix this, but I the C coding standards I checked briefly gave no aid in how to treat this compiler warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant