This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Update docs/dev_guide/intro/mojito_mvc.rst #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the model function "get_photos" needs the callback function as parameter.
| @@ -97,7 +96,7 @@ instructs Mojito to load the YUI module ``yql`` for getting data. | |||
| this.config = config; | |||
| }, | |||
| // Model function to get data | |||
| get_photos: function(flickr_query){ | |||
| get_photos: function(callback, flickr_query){ | |||
There was a problem hiding this comment.
callback should be the second argument instead to follow model pattern.
There was a problem hiding this comment.
right, thanks for the review!
|
Thanks for the quick fix @lazybean, I will let @zhouyaoji to review and merge it. |
zhouyaoji
pushed a commit
that referenced
this pull request
Nov 25, 2012
Update docs/dev_guide/intro/mojito_mvc.rst
|
Thanks @lazybean for your pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the model function "get_photos" needs the callback function as parameter.