This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Y.config.debug is true by default per YUI default settings #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
caridy
commented
Nov 28, 2012
caridy
commented
- we should honor that.
- Making sure that default log level is computed correctly based on the initial definition of logLevelOrder
- moving that default definition to the configuration config.json
… honor that. Making sure that default log level is computed correctly based on the initial definition of logLevelOrder, and moving that default definition to the configuration config.json
| MojitoServer.prototype._configureLogger = function(Y) { | ||
| var logLevel = (Y.config.logLevel || 'debug').toLowerCase(), | ||
| logLevelOrder = Y.config.logLevelOrder || [], | ||
| defaultLogLevel = logLevelOrder[0] || 'info'; |
There was a problem hiding this comment.
Won't logLevelOrder[0] now always be debug, since we're always using config.json?
There was a problem hiding this comment.
@drewfish No, because Y.config.logLevelOrder comes from getAppConfig() from store in the first place, it is set as part of the Y.config early on, and it lands in the _configureLogger through Y.config.logLevelOrder. So, developers my want to redefine that list, in which case the lower priority element does not need to be 'debug' necessarily.
|
+1 |
caridy
added a commit
that referenced
this pull request
Nov 30, 2012
Y.config.debug is true by default per YUI default settings: - we should honor that. - Making sure that default log level is computed correctly based on the initial definition of logLevelOrder - moving that default definition to the configuration config.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.