Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

archtype updates #828

Merged
merged 2 commits into from
Dec 4, 2012
Merged

archtype updates #828

merged 2 commits into from
Dec 4, 2012

Conversation

isao
Copy link
Contributor

@isao isao commented Dec 4, 2012

  • enable -p option for create mojit
  • update app/hybrid mojito controller to 0.5.x

'mojito',
'mojito-assets-addon',
'mojito-models-addon',
'top_frameModelFoo'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has to change to something ala '{{name}}ModelFoo'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an app archetype, which contains a canned "top_frame" mojit, so I think what Isao has is correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's inconsistent, I know. the hybrid archetype is supposed to include both an app and a mojit and the mojit name was hard-coded (was a requirement)

@mojit0
Copy link
Contributor

mojit0 commented Dec 4, 2012

One comment, otherwise +1

@drewfish
Copy link
Contributor

drewfish commented Dec 4, 2012

+1

isao pushed a commit that referenced this pull request Dec 4, 2012
@isao isao merged commit 2fec468 into YahooArchive:develop Dec 4, 2012
isao pushed a commit to isao/mojito that referenced this pull request Dec 4, 2012
This reverts commit 2fec468, reversing
changes made to e716cc5.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants