I don't like the fact that it requires micromanaging from the mod makers ('how do I know what's a good number?')
I prefer a best-effort guess that's good enough, rather than modder micromanagement
There a a few well-known conditionals that we can already assign 'relative values' to - attack/defend 50%, vs type 25%
Unknown conditionals we can assign 25% to I guess? 20%? We can always adjust later

how do I know what's a good number

Well, the modder (or we when managing the vanilla/G&K rules) will have a better idea how often a Bonus will actually apply than any hardcoded stuff - code will slowly become obsolete. And I'm sure gut feeling will give vastly better estimates than what we currently do. How is code to know that when fighting in [Foreign Land] tiles is more valuable than when fighting in [Snow] tiles? This solution can exprss that. Or take "uniques": ["[+33]% Strength <vs [Knight] units>", "[+33]% Strength <vs [Cavalry] units>"] vs "uniques": ["[+33]% Strength <vs [Mounted] units>"] - the existing power eval will weigh the former much higher than the latter though the latter is more powerful. How is code to know...

An alternate approach would be to add the AI power weight to the Conditional object itself, which would be less flexible (can't depend on parameter values) - but true, much simpler for modders. That way at least a coder adding a new Conditional that can affect Strength/power might (or might not) see there's a field to fill...

As I said I'm not entirely happy with this either, but as food for thought it's definitely something.

Oh - I forgot - this will make problems with ranking history getting "jumps" - or when ppl with different versions compare their scores... I'd not do anything about that...

Hmmmmm
I'm okay with this, as long as there's some default value - say 25% or something
I do think that we should add 'sane defaults' clauses to the if, so that the cases where mod makers need to manually override is diminished

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Conflicts have been resolved.

as long as there's some default value

Beg to differ - we can' guess a sensible probability calculation for any new conditional, so we'll get the Wakanda mod over-accumulation sooner or later - unless the default is zero.

And dang merge tool - didn't even ask me about RulesetValidator, it runied that all by itself...

I haven't forgotten about this, I'll try to merge it into the next version
It's "better than current state" for sure

This pull request has conflicts, please resolve those before we can evaluate the pull request.

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

This PR was closed because it has been stalled for 10 days with no activity.