Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modding Bug: [unitTriggerTarget] loses the [promotion] promotion doesn't work if put in UnitPromotions.json #12721

Closed
1 task done
AceHank opened this issue Dec 29, 2024 · 2 comments
Labels

Comments

@AceHank
Copy link

AceHank commented Dec 29, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Game Version

4.14.18

Describe the bug

So turned out [unitTriggerTarget] loses the [promotion] promotion doesn't work if put in UnitPromotions.json. I've tried putting it in various trigger condition with no avail.

I've also tried to put it in Units.json and it works fine.

So far I've tested upon turn end, upon losing 1 hp, upon gaining X status, or unique by itself without any conditional.

Modfile
EoF Beta.zip

Thank you for the great work!

Steps to Reproduce

  1. Play as Celestial Beings or Drow Village
  2. Create Meo and reduces its HP down to below 21
  3. Second Wind promotion supposedly be removed after activating the heal
  4. See error

Screenshots

image
Meo's Second Wind (the star icon) should have been removed

Link to save file

Save file
Promotion Lost Test.zip

Operating System

Windows

Additional Information

At first I thought it was because of the self activating triggerCondition, but Judgement promotion can be self activated.

I also have tried putting the promotion removing unique independent from both related promotions, in case that matter.

@AceHank AceHank added the bug label Dec 29, 2024
@AceHank
Copy link
Author

AceHank commented Jan 1, 2025

So after doing some more testing, turns out, the title is slightly wrong. The uniques doesn't work only when it is placed in UnitPromotions.json.

I've recently tested putting it in Units.json and it works fine!
Which I'm not sure if it's a bug or not, because the loses status counterpart works fine put in UnitPromotions.json.

Thank you!

@AceHank AceHank changed the title Modding Bug: [unitTriggerTarget] loses the [promotion] promotion doesn't work Modding Bug: [unitTriggerTarget] loses the [promotion] promotion doesn't work if put in UnitPromotions.json Jan 1, 2025
@AceHank
Copy link
Author

AceHank commented Jan 2, 2025

Actually, I don't know anymore, I've tested again and now it worked in UnitPromotions.json, BUT, this time I've tested when I picked promotion using XP, and not any other way.

I don't understand it quite yet, but I think I'm gonna close this one as this is most likely my own fault.

Sorry and thank you!

@AceHank AceHank closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant