Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compatibility for Gradle 7.0.0+ on React Native 0.68.1 #407

Open
luisabarca opened this issue Apr 18, 2022 · 2 comments
Open

add compatibility for Gradle 7.0.0+ on React Native 0.68.1 #407

luisabarca opened this issue Apr 18, 2022 · 2 comments

Comments

@luisabarca
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-orientation/android/build.gradle b/node_modules/react-native-orientation/android/build.gradle
index e09fb27..f5b1e04 100644
--- a/node_modules/react-native-orientation/android/build.gradle
+++ b/node_modules/react-native-orientation/android/build.gradle
@@ -16,5 +16,5 @@ android {
 }
 
 dependencies {
-    compile "com.facebook.react:react-native:+"
+    implementation "com.facebook.react:react-native:+"
 }

This issue body was partially generated by patch-package.

@luisabarca luisabarca changed the title update compile to implementation for gradle 7.0.0 on React Native 0.68.1 update compile to implementation for gradle 7.0.0+ on React Native 0.68.1 Apr 18, 2022
@luisabarca luisabarca changed the title update compile to implementation for gradle 7.0.0+ on React Native 0.68.1 add compatibility for Gradle 7.0.0+ on React Native 0.68.1 Apr 18, 2022
@muhammad-ahsan099
Copy link

That answer is perfect!

@Yandamuri
Copy link

I am also facing same issue with Gradle 7.0.0+ on React Native 0.68. I am using react-native-orientation: 3.1.3. The above prescribed solution is working for me too. When will this change be published?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants