Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

課程 API 缺少項目 #8

Open
yanglin5689446 opened this issue Sep 6, 2018 · 3 comments
Open

課程 API 缺少項目 #8

yanglin5689446 opened this issue Sep 6, 2018 · 3 comments

Comments

@yanglin5689446
Copy link
Owner

現在的 API 缺乏：

  • teachers
  • department
  • semester(只有 id 沒有關聯)
  • ratings(現在的 course_ratings 會回傳全部的評分，是否回傳總平均評分就好？)
@austin880625
Copy link
Contributor

之前討論的永久課號問題你怎麼處理的

@karljackab
Copy link

API缺乏teachers和deparment是什麼意思阿？

@yanglin5689446
Copy link
Owner Author

@austin880625 現在還是每個課程對一個永久課程的 model ，然後永久課號在永久課程那邊
@karljackab 課程已經有老師的欄位了，但是系所我當初設計課程 table 時忘記做 relation 的樣子

vava24680 pushed a commit to vava24680/nctuplus-api that referenced this issue Dec 17, 2018
@marmot0814 @vava24680
Backgrounds api2 (yanglin5689446#8)
a870e94 
* backgrounds api without rspec

* add test

* typo

* background_cover_uploader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@austin880625 @yanglin5689446 @karljackab