NodeBB v2 Compatibility

[yariplus]

No description provided.

[SadafGhafoor]

The newsletter plugin is not working after we upgraded NodeBB to version 2.5.7. Kindly fix the issue.

[yariplus]

In progress, should be out soon.

[yariplus]

Unfortunately, due to changes to tinymce, I'll need to change to a different editor, or just remove the editor entirely. Open to suggestions.

[SadafGhafoor]

Any progress on the newsletter plugin?

[yariplus]

Oh, sorry I didn't update the issue, i pushed the update last week. Let me know if you still have issues!

[SadafGhafoor]

The newsletter plugin is still not completely functional. The main body section is disabled and the plugin keeps on loading. Attaching screenshot below:

[yariplus]

Seems like you have something blocking loading of the tinymce script.

Are you able to see the "send as newsletter" dropdown from a new topic?

[SadafGhafoor]

No i am unable to see the newsletter option in dropdown menu in the new topic section

…

On Mon, 14 Nov 2022, 18:13 Timothy Fike, ***@***.***> wrote: Seems like you have something blocking loading of the tinymce script. Are you able to see the "send as newsletter" dropdown from a new topic? — Reply to this email directly, view it on GitHub <#33 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJJMUAPHXDGWH6TPYDR5NRLWII3IJANCNFSM5QBY6RAQ> . You are receiving this because you commented.Message ID: ***@***.***>

[yariplus]

can you screenshot any errors in the browser console?

[aworobel]

Hello,

Same problem here.
Tinymce is not build in assets.

Browser log :

GET https://www.onekite.com/assets/plugins/nodebb-plugin-newsletter/tinymce/tinymce.min.js 404
send @ admin.min.js?v=jmsqiscj4rk:59
ajax @ admin.min.js?v=jmsqiscj4rk:59
f._evalUrl @ admin.min.js?v=jmsqiscj4rk:59
Mn @ admin.min.js?v=jmsqiscj4rk:56
append @ admin.min.js?v=jmsqiscj4rk:56
(anonymes) @ admin.min.js?v=jmsqiscj4rk:56
fe @ admin.min.js?v=jmsqiscj4rk:56
html @ admin.min.js?v=jmsqiscj4rk:56
(anonymes) @ admin.min.js?v=jmsqiscj4rk:9
Promise.then (asynchrone)
(anonymes) @ admin.min.js?v=jmsqiscj4rk:9
(anonymes) @ admin.min.js?v=jmsqiscj4rk:9
Promise.then (asynchrone)
v @ admin.min.js?v=jmsqiscj4rk:9
(anonymes) @ admin.min.js?v=jmsqiscj4rk:9
success @ admin.min.js?v=jmsqiscj4rk:9
V @ admin.min.js?v=jmsqiscj4rk:56
fireWith @ admin.min.js?v=jmsqiscj4rk:56
Kt @ admin.min.js?v=jmsqiscj4rk:59
(anonymes) @ admin.min.js?v=jmsqiscj4rk:59
load (asynchrone)
send @ admin.min.js?v=jmsqiscj4rk:59
ajax @ admin.min.js?v=jmsqiscj4rk:59
ajaxify.loadData @ admin.min.js?v=jmsqiscj4rk:9
ajaxify.go @ admin.min.js?v=jmsqiscj4rk:9
E @ admin.min.js?v=jmsqiscj4rk:9
(anonymes) @ admin.min.js?v=jmsqiscj4rk:9
dispatch @ admin.min.js?v=jmsqiscj4rk:56
Ve.handle @ admin.min.js?v=jmsqiscj4rk:56
plugins-newsletter.e85042a4c8af929ce03b.min.js:1 
        
       Uncaught (in promise) ReferenceError: tinymce is not defined
    at o.init (plugins-newsletter.e85042a4c8af929ce03b.min.js:1:1339)
    at admin.min.js?v=jmsqiscj4rk:9:60591
o.init @ plugins-newsletter.e85042a4c8af929ce03b.min.js:1
(anonymes) @ admin.min.js?v=jmsqiscj4rk:9
Promise.then (asynchrone)
(anonymes) @ admin.min.js?v=jmsqiscj4rk:9
await in (anonymes) (asynchrone)
(anonymes) @ admin.min.js?v=jmsqiscj4rk:9
(anonymes) @ admin.min.js?v=jmsqiscj4rk:9
Promise.then (asynchrone)
ajaxify.loadScript @ admin.min.js?v=jmsqiscj4rk:9
ajaxify.end @ admin.min.js?v=jmsqiscj4rk:9
(anonymes) @ admin.min.js?v=jmsqiscj4rk:9
Promise.then (asynchrone)
(anonymes) @ admin.min.js?v=jmsqiscj4rk:9
(anonymes) @ admin.min.js?v=jmsqiscj4rk:9
Promise.then (asynchrone)
v @ admin.min.js?v=jmsqiscj4rk:9
(anonymes) @ admin.min.js?v=jmsqiscj4rk:9
success @ admin.min.js?v=jmsqiscj4rk:9
V @ admin.min.js?v=jmsqiscj4rk:56
fireWith @ admin.min.js?v=jmsqiscj4rk:56
Kt @ admin.min.js?v=jmsqiscj4rk:59
(anonymes) @ admin.min.js?v=jmsqiscj4rk:59
load (asynchrone)
send @ admin.min.js?v=jmsqiscj4rk:59
ajax @ admin.min.js?v=jmsqiscj4rk:59
ajaxify.loadData @ admin.min.js?v=jmsqiscj4rk:9
ajaxify.go @ admin.min.js?v=jmsqiscj4rk:9
E @ admin.min.js?v=jmsqiscj4rk:9
(anonymes) @ admin.min.js?v=jmsqiscj4rk:9
dispatch @ admin.min.js?v=jmsqiscj4rk:56
Ve.handle @ admin.min.js?v=jmsqiscj4rk:56

[SadafGhafoor]

I did not find any dropdown and send as a Newsletter option.

[yariplus]

Should be the arrow next to the submit button.

[yariplus]

I'll push an update tonight for the tinymce errors.

[yariplus]

Version 0.10.2 should work now

[aworobel]

Hello,

Seems not ok :/
Tried to rebuild.

Uncaught (in promise) ReferenceError: tinymce is not defined
    at o.init (plugins-newsletter.e85042a4c8af929ce03b.min.js:1:1339)
    at admin.min.js?v=h6c21915ifg:9:60591

But found a (very) dirty workaround with a symlink :)

npm i tinymce
cd /opt/nodebb/build/public/plugins
ln -s ../../../node_modules/tinymce/ tinymce

[yariplus]

Huh. That is strange. I never call the tinymce module, I pull it from the cloudflare cdn. Are you sure it updated to 0.10.2?

That does give me an idea for a fix though.

[aworobel]

Indeed i'm in 0.10.2

[iasna]

can you screenshot any errors in the browser console?
yes! On new topic editor i opened console and saw this error.

[iasna]

Also when i click on newsletter from plugins, a page opens up but editor for never shows up. Below is error that showed up in console.

[yariplus]

Thanks guys. I think I see what's going on here. I removed the static directory with tinymce, but that doesn't remove the actual file in the build directory, so it's trying to build with the old files as far as I can tell. I think uninstalling the plugin, rebuilding, than installing it again should work, but I haven't finished testing that yet if anyone wants to try it out.