New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent underflow #103

Open

gpersoon opened this issue Oct 12, 2021 · 0 comments

gpersoon commented Oct 12, 2021

Vulnerability details

An underflow might occur at the following (if accidentally a wrong tokens is supplied):

18 - ExtendedIERC20(tokens[i]).decimals()

In solidity 6.12 the underflow means it will wrap to a large value, resulting in problems later on.

Proof of concept

metavault/contracts/v3/strategies/GeneralConvexStrategy.sol

Line 73 in 8f35c3d

decimalMultiples.push(18 - ExtendedIERC20(tokens[i]).decimals());

Recommended mitigation steps

Use the safeMath sub() function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment