Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NBS] Split huge request #2000

Open
drbasic opened this issue Sep 11, 2024 · 2 comments
Open

[NBS] Split huge request #2000

drbasic opened this issue Sep 11, 2024 · 2 comments
Assignees
@drbasic
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR bug Something isn't working

Comments

@drbasic
Copy link
Collaborator

drbasic commented Sep 11, 2024 •
edited
Loading

На запросы со странными размерами данных, которые нужно прочитать/записать, следует сразу отвечать ошибкой E_ARGUMENT.
Очень большие запросы нужно разбивать на части, так чтобы в TVolumeActor проходили только запросы которые смогут выполнить все типы дисков.
Сделать нужно на уровне cloud/blockstore/libs/service/device_handler.cpp
@drbasic drbasic self-assigned this Sep 11, 2024
@drbasic drbasic added the bug Something isn't working label Sep 11, 2024
@drbasic
Copy link
Collaborator Author

drbasic commented Sep 11, 2024 •
edited
Loading

https://github.com/ydb-platform/nbs/blob/main/cloud/blockstore/libs/client/config.cpp#L55
https://github.com/ydb-platform/nbs/blob/main/cloud/blockstore/libs/service_local/storage_aio.cpp#L482
https://github.com/ydb-platform/nbs/blob/main/cloud/blockstore/libs/storage/disk_agent/disk_agent_state.cpp#L45
https://github.com/ydb-platform/nbs/blob/main/cloud/blockstore/libs/service/device_handler.cpp#L137
https://github.com/ydb-platform/nbs/blob/users/drbasic/validate-request-size/cloud/blockstore/libs/vhost/server.cpp#L32
https://github.com/ydb-platform/nbs/blob/users/drbasic/validate-request-size/cloud/blockstore/libs/nbd/protocol.h#L25
https://github.com/ydb-platform/nbs/blob/main/cloud/blockstore/libs/rdma/iface/client.h#L25

@komarevtsev-d komarevtsev-d added the blockstore Add this label to run only cloud/blockstore build and tests on PR label Sep 11, 2024
@drbasic drbasic mentioned this issue Sep 12, 2024
Closed
@drbasic
Copy link
Collaborator Author

drbasic commented Sep 12, 2024 •
edited
Loading

#2005
#2024
#2026
#2035

@drbasic drbasic mentioned this issue Sep 13, 2024
Merged
@drbasic drbasic changed the title [NBS] Validate request size in TVolumeActor [NBS] Split huge request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drbasic drbasic

Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drbasic @komarevtsev-d