From 0b2f285b751987b093b7547b42154a8354b83976 Mon Sep 17 00:00:00 2001 From: Alexey Ozeritskiy Date: Mon, 29 Jan 2024 13:39:03 +0100 Subject: [PATCH 1/2] Remove broken optimizer YQL-17555 --- ydb/library/yql/providers/dq/opt/physical_optimize.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/ydb/library/yql/providers/dq/opt/physical_optimize.cpp b/ydb/library/yql/providers/dq/opt/physical_optimize.cpp index e2ff322c9d75..43782cc697f8 100644 --- a/ydb/library/yql/providers/dq/opt/physical_optimize.cpp +++ b/ydb/library/yql/providers/dq/opt/physical_optimize.cpp @@ -35,7 +35,6 @@ class TDqsPhysicalOptProposalTransformer : public TOptimizeTransformerBase { AddHandler(0, &TCoPartitionsByKeys::Match, HNDL(BuildPartitionsStage)); AddHandler(0, &TCoShuffleByKeys::Match, HNDL(BuildShuffleStage)); AddHandler(0, &TCoFinalizeByKey::Match, HNDL(BuildFinalizeByKeyStage)); - AddHandler(0, &TDqCnHashShuffle::Match, HNDL(BuildHashShuffleByKeyStage)); AddHandler(0, &TCoPartitionByKey::Match, HNDL(BuildPartitionStage)); AddHandler(0, &TCoAsList::Match, HNDL(BuildAggregationResultStage)); AddHandler(0, &TCoTopSort::Match, HNDL(BuildTopSortStage)); @@ -194,10 +193,6 @@ class TDqsPhysicalOptProposalTransformer : public TOptimizeTransformerBase { return DqBuildShuffleStage(node, ctx, optCtx, *getParents(), IsGlobal); } - TMaybeNode BuildHashShuffleByKeyStage(TExprBase node, TExprContext& ctx, const TGetParents& getParents) { - return DqBuildHashShuffleByKeyStage(node, ctx, *getParents()); - } - template TMaybeNode BuildFinalizeByKeyStage(TExprBase node, TExprContext& ctx, const TGetParents& getParents) { return DqBuildFinalizeByKeyStage(node, ctx, *getParents(), IsGlobal); From 2f63d7eb0f8c797391b200f2f95620f897db3e2e Mon Sep 17 00:00:00 2001 From: Alexey Ozeritskiy Date: Thu, 1 Feb 2024 20:55:37 +0100 Subject: [PATCH 2/2] Canonize --- .../yql/tests/sql/dq_file/part0/canondata/result.json | 6 +++--- .../yql/tests/sql/dq_file/part11/canondata/result.json | 6 +++--- .../yql/tests/sql/dq_file/part12/canondata/result.json | 6 +++--- .../yql/tests/sql/dq_file/part18/canondata/result.json | 6 +++--- .../yql/tests/sql/dq_file/part19/canondata/result.json | 6 +++--- .../yql/tests/sql/dq_file/part8/canondata/result.json | 6 +++--- 6 files changed, 18 insertions(+), 18 deletions(-) diff --git a/ydb/library/yql/tests/sql/dq_file/part0/canondata/result.json b/ydb/library/yql/tests/sql/dq_file/part0/canondata/result.json index 02837b9a08a7..cf238cb38e14 100644 --- a/ydb/library/yql/tests/sql/dq_file/part0/canondata/result.json +++ b/ydb/library/yql/tests/sql/dq_file/part0/canondata/result.json @@ -496,9 +496,9 @@ ], "test.test[blocks-minmax_strings--Debug]": [ { - "checksum": "228cb9ea9ac90b76c19456f64f953232", - "size": 7621, - "uri": "https://{canondata_backend}/1923547/63814b1113aa44b294fe28fd8a7c507858e712bd/resource.tar.gz#test.test_blocks-minmax_strings--Debug_/opt.yql_patched" + "checksum": "ba5191148f3518b0c19272604b9046b1", + "size": 7595, + "uri": "https://{canondata_backend}/937458/e429c288a4c437886f47817d132007f20d3db329/resource.tar.gz#test.test_blocks-minmax_strings--Debug_/opt.yql_patched" } ], "test.test[blocks-minmax_strings--Plan]": [ diff --git a/ydb/library/yql/tests/sql/dq_file/part11/canondata/result.json b/ydb/library/yql/tests/sql/dq_file/part11/canondata/result.json index a14d27a795c1..fd248618006f 100644 --- a/ydb/library/yql/tests/sql/dq_file/part11/canondata/result.json +++ b/ydb/library/yql/tests/sql/dq_file/part11/canondata/result.json @@ -461,9 +461,9 @@ ], "test.test[blocks-distinct_opt_state_keys--Debug]": [ { - "checksum": "d65b917d8a9419005e1d31b6798b6454", - "size": 8409, - "uri": "https://{canondata_backend}/1775319/cbe1478d30f21f8e722d56bbf22e0acf9604e341/resource.tar.gz#test.test_blocks-distinct_opt_state_keys--Debug_/opt.yql_patched" + "checksum": "b105af8748b690ded4ae3e5c816ba130", + "size": 8377, + "uri": "https://{canondata_backend}/937458/7faced6757d14e313801223a395eaf229a366581/resource.tar.gz#test.test_blocks-distinct_opt_state_keys--Debug_/opt.yql_patched" } ], "test.test[blocks-distinct_opt_state_keys--Plan]": [ diff --git a/ydb/library/yql/tests/sql/dq_file/part12/canondata/result.json b/ydb/library/yql/tests/sql/dq_file/part12/canondata/result.json index 0beceeadf1a4..6daa0489d179 100644 --- a/ydb/library/yql/tests/sql/dq_file/part12/canondata/result.json +++ b/ydb/library/yql/tests/sql/dq_file/part12/canondata/result.json @@ -2581,9 +2581,9 @@ ], "test.test[produce-native_desc_reduce_with_presort--Debug]": [ { - "checksum": "4f15c54e3a1d9f2838fc83b114b169d3", - "size": 5065, - "uri": "https://{canondata_backend}/1880306/234eadcde1cd54bffae64f4516628981e02b093d/resource.tar.gz#test.test_produce-native_desc_reduce_with_presort--Debug_/opt.yql_patched" + "checksum": "8f7a0efe0d718bbbd304c63081d76f31", + "size": 5063, + "uri": "https://{canondata_backend}/1031349/d3a88498ca54cabc05c19bf5a97272e7679a8ab7/resource.tar.gz#test.test_produce-native_desc_reduce_with_presort--Debug_/opt.yql_patched" } ], "test.test[produce-native_desc_reduce_with_presort--Plan]": [ diff --git a/ydb/library/yql/tests/sql/dq_file/part18/canondata/result.json b/ydb/library/yql/tests/sql/dq_file/part18/canondata/result.json index 8dbabdfb54fb..384f23963af2 100644 --- a/ydb/library/yql/tests/sql/dq_file/part18/canondata/result.json +++ b/ydb/library/yql/tests/sql/dq_file/part18/canondata/result.json @@ -2225,9 +2225,9 @@ ], "test.test[produce-reduce_with_presort_diff_order--Debug]": [ { - "checksum": "1bdf38d171a1a7c8a21efa733394d6a5", - "size": 10751, - "uri": "https://{canondata_backend}/1880306/e4ccac619cc79d4b07e7e803e386d47da238c793/resource.tar.gz#test.test_produce-reduce_with_presort_diff_order--Debug_/opt.yql_patched" + "checksum": "4d4af14bdf9566a1e25c4b0424f1ac95", + "size": 10745, + "uri": "https://{canondata_backend}/1781765/bfbc14fbca83410d3f2959ca7e0fde3ab8aa1e5a/resource.tar.gz#test.test_produce-reduce_with_presort_diff_order--Debug_/opt.yql_patched" } ], "test.test[produce-reduce_with_presort_diff_order--Plan]": [ diff --git a/ydb/library/yql/tests/sql/dq_file/part19/canondata/result.json b/ydb/library/yql/tests/sql/dq_file/part19/canondata/result.json index a65c9617027f..606fb798204d 100644 --- a/ydb/library/yql/tests/sql/dq_file/part19/canondata/result.json +++ b/ydb/library/yql/tests/sql/dq_file/part19/canondata/result.json @@ -583,9 +583,9 @@ ], "test.test[blocks-distinct_mixed_keys--Debug]": [ { - "checksum": "3f5f5d88f8e32a273df8314fee3bc4ee", - "size": 7791, - "uri": "https://{canondata_backend}/1871182/a9fec6130ebf2c725dfb5b780cfaf44525bc35bf/resource.tar.gz#test.test_blocks-distinct_mixed_keys--Debug_/opt.yql_patched" + "checksum": "1e18327f0f8afda71567632fd5a00fc8", + "size": 7759, + "uri": "https://{canondata_backend}/1925842/7427ad0789e1bf3c794895672d9ff33e12496171/resource.tar.gz#test.test_blocks-distinct_mixed_keys--Debug_/opt.yql_patched" } ], "test.test[blocks-distinct_mixed_keys--Plan]": [ diff --git a/ydb/library/yql/tests/sql/dq_file/part8/canondata/result.json b/ydb/library/yql/tests/sql/dq_file/part8/canondata/result.json index 89ceedb24bbd..5818bdf632e0 100644 --- a/ydb/library/yql/tests/sql/dq_file/part8/canondata/result.json +++ b/ydb/library/yql/tests/sql/dq_file/part8/canondata/result.json @@ -440,9 +440,9 @@ ], "test.test[aggregate-native_desc_group_compact_by--Debug]": [ { - "checksum": "a7a130a207b4a32aca971b8b070ed24c", - "size": 5851, - "uri": "https://{canondata_backend}/1937027/d3548eb0e12456df7d78d12789a5f6e6325fd027/resource.tar.gz#test.test_aggregate-native_desc_group_compact_by--Debug_/opt.yql_patched" + "checksum": "d26cf2f68f28c91208aa70ce3c9b499a", + "size": 5850, + "uri": "https://{canondata_backend}/1936273/8bb3f5967bd29373cf89b0836208cb6468397833/resource.tar.gz#test.test_aggregate-native_desc_group_compact_by--Debug_/opt.yql_patched" } ], "test.test[aggregate-native_desc_group_compact_by--Plan]": [