Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immutable.java:36-38: Replace all the... #1730

Open
0pdd opened this issue Sep 3, 2024 · 3 comments
Open

Immutable.java:36-38: Replace all the... #1730

0pdd opened this issue Sep 3, 2024 · 3 comments

Comments

@0pdd
Copy link
Collaborator

0pdd commented Sep 3, 2024

The puzzle 898-3f27c8c5 from #898 has to be resolved:

* @todo #898:30min Replace all the Collections.unmodifiableCollection
* with the {@link Immutable} from the cactoos codebase.
* That should be done because Elegant Object principles are against static methods.

The puzzle was created by Yegor Bugayenko on 30-Jul-22.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@catdog905
Copy link

@yegor256 Hello, I tried to search unmodifiableCollection word, but it seems there is no a single occurrence. What did you mean?

yaroslav@xiaomao ~/G/cactoos (master)> pwd
/home/yaroslav/GithubRepos/cactoos
yaroslav@xiaomao ~/G/cactoos (master)> grep -rnw '.' -e 'unmodifiableCollection'
./src/main/java/org/cactoos/collection/Immutable.java:36: * @todo #898:30min Replace all the Collections.unmodifiableCollection
./target/site/jacoco/org.cactoos.collection/Immutable.java.html:36: * @todo #898:30min Replace all the Collections.unmodifiableCollection
yaroslav@xiaomao ~/G/cactoos (master)> git log
commit 4482ed917d82a9275f0d75986e508f4b9e6ad524 (HEAD -> master, upstream/master)
Merge: b6f0d637 7a0f5919
Author: Yegor Bugayenko <[email protected]>
Date:   Tue Nov 26 15:00:30 2024 +0300

    Merge pull request #1749 from HaidarJbeily7/master
    
    Feat: add support for negative value to get tail from the string

@yegor256
Copy link
Owner

@catdog905 in this case, just delete the puzzle from the source code and that's it

@catdog905
Copy link

@yegor256 done. Also it looks like there is a duplicate issue #1645 describing the same pdd task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants