Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to validate when keys are JSON-LD keywords #3

Open
kelvinqian00 opened this issue Aug 8, 2019 · 0 comments
Open

Failure to validate when keys are JSON-LD keywords #3

kelvinqian00 opened this issue Aug 8, 2019 · 0 comments

Comments

@kelvinqian00
Copy link
Collaborator

kelvinqian00 commented Aug 8, 2019

Issue: When validating keys that are JSON-LD keywords such as @id and @type (rather than the aliased variants id and type that do not have the @ symbol), the library fails to recognize the keys and declares them missing.

Reproduction: Run validate-profile on the cmi5 profile, which uses @id and @type rather than id and type.

Does this need to be fixed? Maybe, but also maybe not. After all, although @id and @type are legal keywords in JSON-LD, the xAPI Profile spec defines these properties assuming they are the aliased versions. So the context namespace should have these cases in mind, but the rest of the library do not need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant