Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: implement integration test for zkSync contracts #186

Open
JuArce opened this issue Mar 21, 2024 · 0 comments
Open

build: implement integration test for zkSync contracts #186

JuArce opened this issue Mar 21, 2024 · 0 comments
Assignees

Comments

@JuArce
Copy link
Collaborator

JuArce commented Mar 21, 2024

This issue is a continuation of #171

To assure correct functionality of ZKSync contract in every future change, an integration test will run inside the CI (github workflow) that deploys the necesarry contracts and executes the whole process of a bridge:
-set_order
-transfer
-claim_payment

If this test fails: either:
-a breaking change is trying to be pushed to main, which is a mistake.
-the integration test must be updated (for example the name of a called function has been updated)

For this, the Dockerized L1-L2 nodes is currently being used, but setup-dev is under analysis of being used, since it is more used around the industry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants