Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove: mm_ethereum_wallet variable from SN Escrow #244

Open
uri-99 opened this issue Apr 17, 2024 · 0 comments
Open

remove: mm_ethereum_wallet variable from SN Escrow #244

uri-99 opened this issue Apr 17, 2024 · 0 comments
Assignees

Comments

@uri-99
Copy link
Collaborator

uri-99 commented Apr 17, 2024

This variable is unused and unnecessary.

Need to remove it from:

  • Storage
  • Constructor
  • Deploy script
  • Tests

We could also use this PR to remove the parameter "from_address" from the _claim_payment() function call. It is also unused and unnecessary.

@uri-99 uri-99 self-assigned this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant