Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid can't build #58

Open
licaon-kter opened this issue Jun 3, 2024 · 4 comments
Open

F-Droid can't build #58

licaon-kter opened this issue Jun 3, 2024 · 4 comments

Comments

@licaon-kter
Copy link

licaon-kter commented Jun 3, 2024

...as the submodule used by F-Droid was deemed "unused": ca45b37

maybe we can set it up as a srclib instead, but we don't have a version reference: https://github.com/yggdrasil-network/yggdrasil-android/blob/v0.1-017/.github/workflows/android.yml#L26 since the submodule was providing that

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/aad111d43d8fae946c23fad838f305cb524df965

@neilalexander
Copy link
Member

This is likely my fault as I didn't know that there were F-Droid builds depending upon that submodule. It can be added back if so.

@licaon-kter
Copy link
Author

Like I said, we used the submodulex for that, as that's usable for you too, eg. Use it in your CI, and then it's a given that you don't forget to update

We can extract the exact version of it from a file, but devs tend to forget to update those too :))

@neilalexander
Copy link
Member

Happy to use the submodule for CI too. Right now it just pulls in the latest:

- name: Check out Yggdrasil
uses: actions/checkout@v3
with:
repository: yggdrasil-network/yggdrasil-go
path: yggdrasil-go
ref: master
fetch-depth: 0

... but I'm happy to take the recommendation to use the submodule for both for consistency.

@Revertron
Copy link
Collaborator

So, what are we doing? I'm ready to release something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants