Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not change all URLs to original #4

Open
eaglexer opened this issue May 21, 2018 · 0 comments
Open

Does not change all URLs to original #4

eaglexer opened this issue May 21, 2018 · 0 comments

Comments

@eaglexer
Copy link

eaglexer commented May 21, 2018

This is an excellent project! Thanks for this.
But in page.js your script does not change all URLs because it changes only in span.notranslate. I suppose that in all tags a you need to change the URL.

Your code:
$notranslate.children('a').each(function (index, item) {
let $item = $(item)
let href = $item.attr("href")
href = href && queryString.parse(url.parse(href).query).u
$item.attr("href", href)
})

My solution:
$('a').each(function (index, item) {
let $item = $(item)
let href = $item.attr("href")
href = href && queryString.parse(url.parse(href).query).u
$item.attr("href", href)
})

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant