-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AY-6975 Consolidate retimes computation. #1087
base: develop
Are you sure you want to change the base?
Conversation
Task linked: AY-6975 Broken retiming calculation |
Tested current dev and all is passing fine
|
frame_range = [media_in_trimmed] | ||
in_frame = media_in_trimmed + time_scalar | ||
while in_frame <= media_out_trimmed: | ||
frame_range.append(in_frame) | ||
in_frame += time_scalar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If time_scalar
is int
then this can be simplified to:
frame_range = [media_in_trimmed] | |
in_frame = media_in_trimmed + time_scalar | |
while in_frame <= media_out_trimmed: | |
frame_range.append(in_frame) | |
in_frame += time_scalar | |
frame_range = list(range( | |
media_in_trimmed, | |
media_out_trimmed + 1, | |
time_scalar | |
)) |
If is float
then this is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
time_scalar might be float
(unfortunately 😞)
Changelog Description
help resolve ynput/ayon-hiero#29
help resolve ynput/ayon-flame#28
[ ] Retiming is not properly applied on reviewable, will be handled in a separate PR if needed.`Additional info
This needs to be tested alongside:
Testing notes:
.\tools\manage.ps1 run pytest .\tests\