Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AY-6975 Consolidate retimes computation. #1087

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

robin-ynput
Copy link
Contributor

@robin-ynput robin-ynput commented Jan 15, 2025

Changelog Description

help resolve ynput/ayon-hiero#29
help resolve ynput/ayon-flame#28

  • FreezeFrame does not work due to wong available media range boudary computation
  • Negative speed is not always accurate
  • TimeWrap is not properly computed
  • LinearTimeWarp produce correct output clip (tried speed = 0.5 and speed = 2), retime information can be properly gathered from Nuke.
  • [ ] Retiming is not properly applied on reviewable, will be handled in a separate PR if needed.`

Additional info

This needs to be tested alongside:

Testing notes:

  1. Run the automated tests
    .\tools\manage.ps1 run pytest .\tests\

@ynbot
Copy link
Contributor

ynbot commented Jan 15, 2025

Task linked: AY-6975 Broken retiming calculation

@robin-ynput robin-ynput self-assigned this Jan 15, 2025
@robin-ynput robin-ynput added type: bug Something isn't working tests PR contains new unit or integration test or improves the existing ones labels Jan 15, 2025
@jakubjezek001
Copy link
Member

Tested current dev and all is passing fine

===================================== 28 passed, 17 warnings in 1.11s =====================================

Comment on lines 434 to 438
frame_range = [media_in_trimmed]
in_frame = media_in_trimmed + time_scalar
while in_frame <= media_out_trimmed:
frame_range.append(in_frame)
in_frame += time_scalar
Copy link
Member

@iLLiCiTiT iLLiCiTiT Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If time_scalar is int then this can be simplified to:

Suggested change
frame_range = [media_in_trimmed]
in_frame = media_in_trimmed + time_scalar
while in_frame <= media_out_trimmed:
frame_range.append(in_frame)
in_frame += time_scalar
frame_range = list(range(
media_in_trimmed,
media_out_trimmed + 1,
time_scalar
))

If is float then this is better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

time_scalar might be float (unfortunately 😞)

@robin-ynput robin-ynput marked this pull request as ready for review January 22, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Resolve size/XL tests PR contains new unit or integration test or improves the existing ones type: bug Something isn't working
Projects
Status: Review In Progress
Development

Successfully merging this pull request may close these issues.

Bring back publishing of clip retimes AY-6975_Broken retiming calculation
4 participants