Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task 1.f Remove for loop in epimutations detection #13

Open
yocra3 opened this issue Nov 4, 2020 · 1 comment
Open

Task 1.f Remove for loop in epimutations detection #13

yocra3 opened this issue Nov 4, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone
Enhanced epimutat...

Comments

@yocra3
Copy link
Owner

yocra3 commented Nov 4, 2020

In EpiMutation function, a for loop iterates over the epimutations detected. This for loop it is inefficient and should be removed.
@yocra3 yocra3 added the enhancement New feature or request label Nov 4, 2020
@yocra3 yocra3 added this to the Enhanced epimutations discovery milestone Nov 4, 2020
@yocra3 yocra3 mentioned this issue Nov 4, 2020
Open
7 tasks
@yocra3 yocra3 changed the title Remove for loop in epimutations detection Task 1.f Remove for loop in epimutations detection Nov 6, 2020
@jamesbaye
Copy link
Collaborator

@yocra3 How would you suggest improving this? If we put all the beta.values in a list and lapply (EpiMANOVA, epiMLM, etc.) over the list, it will probably still run at the same speed since those functions are custom R functions with overhead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Enhanced epimutations discovery
Development

No branches or pull requests
2 participants
@yocra3 @jamesbaye