-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration fails if a comment is present on line with semicolon #208
Comments
There is a special syntax for splitting multiple statements. It could be that ; in comments is tripping up the parser. |
Probably related to that. Though note that there is no semicolon in the comments that cause the issue. |
Yeah, will have to take a closer look at this. If you have time to take a look in the meantime, a PR would be very welcome. :) |
This bug is easy to figure out and correct, and easy to avoid. Not wanting to get into parsing code (major reason I use LISPs!) would you like for now a PR to the README.md? If so where should that go? There's no bugs section, which might logically go just before Setup. This sort of single statement file contents thing is only covered in the Quick Start but it probably shouldn't be polluted with this. I could also add on or more obvious things I noted like use :datasource instead of :connection when you've got the former. Otherwise everything worked right the first time, thanks a lot! |
Maybe could add a gotchas section at the end for now, if you'd be up do a PR for that would be much appreciated. |
A migration like
will fail with the error
while a migration like
will work just fine. My guess would be that some sort of line splitting on semicolons is at hand, but that is just a wild guess.
The text was updated successfully, but these errors were encountered: