You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My Clojure is a little rusty so I can’t open a PR for this right now, but I’d like to at least make this suggestion because I just lost an hour trying to debug why my giant migration wasn’t working… turns out my migration contained dozens of statements as a single “command” — i.e. it wasn’t using the delimiter that is required as per the readme.
My rationale for this suggestion is that:
This just cost me an hour, and while I am rusty with Clojure, I am pretty experienced
I’ve found multiple other issues opened by people who encountered this problem over the years
it’s just very easy to miss that bit in the readme
especially since some other migrations frameworks do support multiple statements in a single .sql file
I would think it could be fairly easy to implement
e.g. something as simple as checking whether a command contains two or more instances of a semicolon followed by a linefeed might be helpful
The text was updated successfully, but these errors were encountered:
That sounds reasonable to me, could do a a heuristic check on the sql file content to see if it looks like it has multiple statements in it and warn. I've been bitten by this myself before actually, so I definitely understand the pain here. :)
@yogthos I encountered a similar issue myself, and I’d like to fix it by implementing the solution discussed here. Would it be okay if I submitted a PR to address this? Please let me know if that works!
My Clojure is a little rusty so I can’t open a PR for this right now, but I’d like to at least make this suggestion because I just lost an hour trying to debug why my giant migration wasn’t working… turns out my migration contained dozens of statements as a single “command” — i.e. it wasn’t using the delimiter that is required as per the readme.
My rationale for this suggestion is that:
.sql
fileThe text was updated successfully, but these errors were encountered: