-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sentence parsing for {sentence}
handlebar sometimes buggy.
#1636
Comments
Yomitan version 24.12.18.1 A similar issue happens (sometimes) when using the Mokuro reader as well (Microsoft Edge).
A random example from よふかしのうた volume 3, page 61: "いかない" in the right bubble on the left panel results in the sentence on the card being:
The only "Volume" I could find on the page was this hidden Svelte div at a different level of the HTML:
Doing the same workflow but on the left bubble of the same panel does not result in a "Volume" being appended at the end for some reason. If you reload the page that directly links to the volume, the "svelte-announcer" div is empty (no "Volume" text) so the issue goes away. That div's text is only populated if you navigate to different pages (seems to be some internal Svelte state tracker going from "Mokuro" to "Manga" to "Volume" as you navigate those levels of the site), but when it is populated is when the issue can happen. Enabling "layout-aware scanning" solves the problem in that "Volume" is no longer pulled in as part of the sentence for this example, but it no longer reliably concatenates the paragraph elements for the full sentence which is not desirable either. Like in this case, it results in:
Which is missing the last bit of text, "ナズナ", from the overall div:
|
Same issue: #1648. Yomitan grabs near standing strings. |
Version: 24.11.23.0
YomitanPowerful and versatile pop-up dictionary for language learning used by 50,000+ language learners.
It's not resolved by turning on "layout-aware scanning".
Similar problem: https://old.reddit.com/r/LearnJapanese/comments/1h1islv/daily_thread_simple_questions_comments_that_dont/lzdnfqn/
The text was updated successfully, but these errors were encountered: