Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug reports (3 listed) #117

Open
3 tasks done
Zeeex opened this issue Aug 16, 2023 · 2 comments
Open
3 tasks done

Small bug reports (3 listed) #117

Zeeex opened this issue Aug 16, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Zeeex
Copy link

Zeeex commented Aug 16, 2023

Steps to reproduce

First and foremost, this app is amazing and beautiful. Using it is simply delightful. 💜

Didn't want to split bugs found into multiple tickets, because they are probably easy to fix.

  1. Occasionally, a lowercase "timeout" toast emerges. It's uncertain whether this is related to the service provider "Wallhaven" or the in-app functionality. Would be nice to get a more verbose message so we know what happened.

  2. When you rotate your phone with auto rotation on, scroll position resets to 0, resulting in the loss of your current position.

  3. When in landscape mode, images get cropped even if they are in portrait mode. Height should be increased to accommodate their original (near original) height.

Expected behavior

  1. Include detailed message on what error occurred, and perhaps provide guidance on the necessary steps to take.
  2. Scroll position should be maintained when rotating your phone.
  3. Images should be full visible (or at least give us an option to toggle the full / cropped view).

Actual behavior

  1. Sometimes toast displays with no explanation.
  2. Scroll position resets to 0 on rotating phone.
  3. Images height in landscape mode is cropped.

Wall You version

5.0

Android version

Android 9

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@Zeeex Zeeex added the bug Something isn't working label Aug 16, 2023
@Bnyro
Copy link
Member

Bnyro commented Aug 19, 2023

  1. means that wallhaven doesn't respond - I don't think we should add extra custom error messages for any possible error (network, timeout, dns, ...)
  2. is certainly UX unfriendly, thus that's reasonable to address.
  3. has been adressed in Fix large screen layout #115.

@Zeeex
Copy link
Author

Zeeex commented Aug 19, 2023

  1. 👍
  2. Maybe some message like "Wallhaven - timeout", so we know it's the service / network issue, and not in-app problem. But I'm ok with not changing it either.
  3. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants