Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update github pages links #2969

Merged
merged 14 commits into from
Nov 3, 2024
Merged

docs: update github pages links #2969

merged 14 commits into from
Nov 3, 2024

Conversation

tskxz
Copy link
Contributor

@tskxz tskxz commented Oct 30, 2024

As referred to in this issue #2967 I updated the links

Copy link
Contributor

@TBBle TBBle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look, and a bunch of places now have a double-/ in the page URL. I guess you did a search-replace from containers.github.io/youki to youki-dev.github.io/youki/ and now there's a few URLs like https://youki-dev.github.io/youki//community/introduction.html in the docs.

URLs that previously ended with youki have become URLs that end with youki/, and that change looks correct to me (the site redirects to have the trailing / in this case) so it's only the double-// that need to be fixed.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/src/developer/documentation_mdbook.md Outdated Show resolved Hide resolved
tools/wasm-sample/README.md Outdated Show resolved Hide resolved
tskxz and others added 5 commits October 31, 2024 18:38
Co-authored-by: Paul "TBBle" Hampson <[email protected]>
Co-authored-by: Paul "TBBle" Hampson <[email protected]>
Co-authored-by: Paul "TBBle" Hampson <[email protected]>
Co-authored-by: Paul "TBBle" Hampson <[email protected]>
@tskxz
Copy link
Contributor Author

tskxz commented Oct 31, 2024

I had a look, and a bunch of places now have a double-/ in the page URL. I guess you did a search-replace from containers.github.io/youki to youki-dev.github.io/youki/ and now there's a few URLs like https://youki-dev.github.io/youki//community/introduction.html in the docs.

URLs that previously ended with youki have become URLs that end with youki/, and that change looks correct to me (the site redirects to have the trailing / in this case) so it's only the double-// that need to be fixed.

Thanks for noticing it, I think now it should be fine and fixed.

@utam0k utam0k added kind/experimental `/experimental` kind/documentation and removed kind/experimental `/experimental` labels Nov 2, 2024
@utam0k
Copy link
Member

utam0k commented Nov 3, 2024

Thanks!

@utam0k utam0k merged commit 6e1a8cf into youki-dev:main Nov 3, 2024
29 checks passed
@github-actions github-actions bot mentioned this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants