[telemetry] Add telemetry to SbPlayerWriteSamples #4097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borongc
force-pushed
the
telemetry_sbplayer_write_samples
branch
2 times, most recently
from
75d2d7c
to
9d21512
Compare
at-ninja
approved these changes
Sep 10, 2024
borongc
force-pushed
the
telemetry_sbplayer_write_samples
branch
from
9d21512
to
eaecf86
Compare
at-ninja
approved these changes
Sep 10, 2024
joeltine
approved these changes
Sep 10, 2024
Adding additional Media Telemetry to cover SbPlayerWriteSamples. The rough range of each function: 1. When batched write is enabled (Media.MaxAudioSamplesPerWrite=256): 1. SbPlayerWriteSamples()/audio: 1us to 98us 2. SbPlayerWriteSamples()/video: 1us to 3.4ms 2. When batched write is disabled (Media.MaxAudioSamplesPerWrite=1): 1. SbPlayerWriteSamples()/audio: 9us to 65.47ms 2. SbPlayerWriteSamples()/video: 8us to 28.07ms b/303328238
borongc
force-pushed
the
telemetry_sbplayer_write_samples
branch
from
eaecf86
to
916f13a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding additional Media Telemetry to cover SbPlayerWriteSamples.
The rough range of each function:
b/303328238