Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be some permissible threshold when joining shapes. #11

Open
sagarjauhari opened this issue Oct 12, 2015 · 1 comment
Open

Comments

@sagarjauhari
Copy link

When joining shapes, there could be a permissible threshold for the distance so that the shapes would be joined even if the edges were not exactly overlapping but close enough (within that threshold)

@yqlu
Copy link
Owner

yqlu commented Oct 13, 2015

There is indeed a fuzzy equals for detecting whether two edges should be joined -- see here, which calls approxEqEdges (which has a default tolerance of 1 pixel).

In my experience this tolerance is sufficient to automatically join two edges which visually look like they should be joined. Do you have an example where it is too low?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants