Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shapes are not replenished reliably #6

Open
void-elf opened this issue Aug 17, 2015 · 8 comments
Open

Shapes are not replenished reliably #6

void-elf opened this issue Aug 17, 2015 · 8 comments

Comments

@void-elf
Copy link

Hi YQ,

I've been having some bugs with the app on Google Chrome (Version 44.0.2403.155 (64-bit)) when running on Ubuntu 14.04. Sometimes I drag a shape from the sidebar to the main view and a replacement doesn't appear. To get the replacement to appear, I just keep clicking around until another shows up. There's no set number of clicks I have to do.

Actual logs from JS console in Chrome (but they kind of suck):
https://gist.github.com/ynasser/83e24f0b0b9f50dbf742

Screenshot of the JS console error output:
desktop 1_031

Yomna

@yqlu
Copy link
Owner

yqlu commented Aug 17, 2015

Thanks Yomna! I haven't seen this before and will look into this over the next week.

@yqlu
Copy link
Owner

yqlu commented Aug 20, 2015

Hmm @ynasser do you know a way to reproduce this error? Alternatively, can you help give more details so I can track this down better:

  • does this happen reliably or sporadically?
  • approx how many tiles are in the main view when this took place?
  • which palette of tiles are you using?
  • what actions did you take before this took place? (copying, deleting tiles, adding patterns, switching back and forth from strip view ...?)

Thanks! I'm using the same version of Chrome on OS X, but I don't think the OS should be affecting this.

@yqlu
Copy link
Owner

yqlu commented Aug 20, 2015

For context, the error messages are occuring because after dragging, deleting or copying, the app calls the function checkRep() that verifies that the data structures are all consistent. The logs show that canvas and polylist are out of sync (both should have the same number of elements), but I can't yet figure out what combination of actions is causing this.

@void-elf
Copy link
Author

Answers to your questions:

  • It happens roughly every other time I use the app (and I use it a lot to
    make diagrams).
  • of tiles ... anywhere from 0 to 10? Often it starts working again and

    then breaks again.
  • I've only use the default palette of tiles.
  • I don't usually do anything else before I start moving shapes to the
    canvas and attaching them to each other. Often delete and copy don't work,
    and I think there's a correlation between they aren't working and when
    shapes aren't being replenished properly.

I can try to take a video with the JS console log open if that would help?

On Thu, Aug 20, 2015 at 2:53 AM, yqlu [email protected] wrote:

For context, the error messages are occuring because after dragging,
deleting or copying, the app calls the function checkRep() that verifies
that the data structures are all consistent. The logs show that canvas and
polylist are out of sync (both should have the same number of elements),
but I can't yet figure out what combination of actions is causing this.


Reply to this email directly or view it on GitHub
#6 (comment).

@yqlu
Copy link
Owner

yqlu commented Aug 20, 2015

If you can, that would be very helpful, thanks!

@void-elf
Copy link
Author

Here's a video where I mess around until all the shapes on the left disappear: https://www.youtube.com/watch?v=FCxsjqZnFiA

This time, no errors appeared in the console :/

@yqlu
Copy link
Owner

yqlu commented Aug 24, 2015

Thanks for the video! I tried out your sequence of steps on my computer, but the shapes were replenishing consistently. I thought it was unlikely that the OS was playing a factor, but I'm going to borrow a windows / ubuntu computer to see if this issue occurs for me there.

Appreciate all your input so far. Can you perform the exact same steps in the video a few times and see if the same shapes disappear each time (i.e. is the bug deterministic?)?

Also, here's a potential workaround for now: if/when the shapes disappear from the sidebar, select another set of shapes from the dropdown menu (e.g. squares and octagons). Now the sidebar should just have a square and an octagon. If you go to the dropdown menu again and reselect your original set of shapes (triangles, squares and hexagons), do all three shapes get repopulated in the sidebar?

Let me know if this workaround helps unblock any design work / experiments you're doing in Wallpaper while I pin down the bug!

@void-elf
Copy link
Author

Thanks for all your help so far! I appreciate the workaround you suggested and will definitely try it.

The bug doesn't appear to be deterministic, i.e. sometimes I just refresh the page and repeat the exact same set of steps and everything works OK. That being said, I'll still try to repeat steps and record videos of what happens sometime in the next weeks so you'll have better data to look at. By the way, you can use an Ubuntu VM for testing instead of borrowing someone's computer.

By the way, I'm using your app for a class I'm taking with Craig Kaplan on tiling theory and Islamic star patterns. He pointed me to it as a way to easily make certain kinds of diagrams for my assignments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants