Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pause between reported hit and claim #7

Open
chaos5235 opened this issue Jul 26, 2024 · 3 comments
Open

pause between reported hit and claim #7

chaos5235 opened this issue Jul 26, 2024 · 3 comments

Comments

@chaos5235
Copy link
Contributor

chaos5235 commented Jul 26, 2024

at the moment there is a big timegap between the announcement of a hit and claim announcement - could that be reduced ?

@chaos5235
Copy link
Contributor Author

maybe the timegap is larger in demo mode. . . . have to re-check that in live

@MrMap
Copy link

MrMap commented Aug 14, 2024

The time gap is present also in non demo mode and kind of wasting time, especially when events come as bursts.
"Target was hit
...............................
Score to Bender"

Could it instead be announced like:
"Target hit by Bender" ?

More time efficient.

@ysoldak
Copy link
Owner

ysoldak commented Sep 23, 2024

I understand frustration. This was a sort of experiment to announce everything, since not all hits are claimed.
It can be a HIT message comes and no CLAIM follow. In that case there will be just "Target was hit".

The lady announces these events separately, she does not keep track who hits whom, she just increments counters and makes an announcement, it's us humans make connection when announcements follow each other closely.

This also helps to keep the implementation simple[r], since we don't need to keep state on Lady's side and resolve who hit whom.

We could improve though, since clearly the current implementation makes announcements slower. We can try and wait a bit with "was hit" announcement and merge it with "Score" announcement if it comes, otherwise just announce "was hit" if CLAIM never comes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants