Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Git Based Resolver #98

Open
davinci26 opened this issue Aug 23, 2022 · 1 comment
Open

[Feature] Git Based Resolver #98

davinci26 opened this issue Aug 23, 2022 · 1 comment
Assignees

Comments

@davinci26
Copy link
Collaborator

davinci26 commented Aug 23, 2022

The way we use VCL and manage dependencies at $company is by having them versioned in a separate git repository and I would like to build a git file resolver that allows you to resolve paths based on path:version and then use git show $REV:$FILE to get the file rather than just reading it from disk

So the proposed changes are:

  • GitFileResolver that implements the Resolver interface
  • func NewGitFileResolvers(main string, c *Config) ([]Resolver, error) and switch between the two implementations based on the command line flag

Addition of two command line flags:

  • -repo : Path to the git repo that contains the modules
  • -git : Use git to read versioned files that in the form of path/to/file/:version

WDYT?

@davinci26
Copy link
Collaborator Author

I have this implemented just wanted to push it the upstream rather than having this patch on our fork.

I believe this might be useful for other people who version their VCL dependencies

@davinci26 davinci26 mentioned this issue Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants