Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 1.20.2 can not view skin #226

Closed
wants to merge 4 commits into from
Closed

fix 1.20.2 can not view skin #226

wants to merge 4 commits into from

Conversation

xmdhs
Copy link

@xmdhs xmdhs commented Oct 14, 2023 •
edited
Loading

1.20.2 更新了 authlib 版本，并把 Property 改为 record 类。且 net.minecraft.client.resources.SkinManager 中改成了默认获取带有签名的皮肤，导致在 1.20.2 无法加载皮肤。

这个 pr 尝试修复这个问题，我对于 javaagent 不是很了解，这样判断应该有些问题。我自己的测试中皮肤是已经可以加载，服务器中也是。

issues: #225

xfl03
xfl03 requested changes Oct 15, 2023
View reviewed changes
Copy link
Collaborator

@xfl03 xfl03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不能默认isSignatureValid方法一定在signature后面被visit

@xmdhs
Copy link
Author

xmdhs commented Oct 15, 2023

改成为 Property 添加回 getter，麻烦看看有什么问题

HongYunCloud

This comment was marked as duplicate.

Sign in to view

@yushijinhun yushijinhun mentioned this pull request Nov 1, 2023
Merged
@yushijinhun
Copy link
Owner

Thank you for the pull request. I've actually implemented a different solution to address the bug (f6970a5).

@yushijinhun yushijinhun closed this Nov 1, 2023
@YuxuanZuo YuxuanZuo mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HongYunCloud HongYunCloud HongYunCloud requested changes

@xfl03 xfl03 xfl03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xmdhs @yushijinhun @xfl03 @HongYunCloud