Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor contrast in the chat history UI #1013

Open
yvt opened this issue May 7, 2022 · 2 comments
Open

Poor contrast in the chat history UI #1013

yvt opened this issue May 7, 2022 · 2 comments
Labels
bug some feature is broken help-needed

Comments

@yvt
Copy link
Owner

yvt commented May 7, 2022

The texts are shown in the sender's team color on a dark background, so they can be hard or impossible to read in some cases.

@yvt yvt added bug some feature is broken help-needed labels May 7, 2022
@yvt yvt changed the title Poor contrast of the chat history UI Poor contrast in the chat history UI May 7, 2022
@notgif
Copy link
Contributor

notgif commented May 12, 2022

I might be able to have a go at this if I can get myself back up to speed with freetype.
I presume the relevant files are going to include some subset of:

- ChatLogWindow.as
- UIFramework.as

- ClientUI*
- FTfont
- Other 'Font' titled sources?

Also the text on macOS [retina] is a bit blurry* — I remember doing something about retina screens and hinting when I last used freetype but im a bit rusty. If I can think of what it was I'll give it a go and see what happens.
*I might do a build on an old laptop so I actually have a baseline though

@yvt
Copy link
Owner Author

yvt commented May 12, 2022

Yep, ChatLogWindow is the component for rendering the chat history UI. It internally uses TextViewer to display chat texts.

One possibly way to address this issue is to update TextViewer to draw white glow around texts like ChatWindow does:

float luminosity = color.x + color.y + color.z;
font->DrawShadow(ch, MakeVector2(tx + winX, ty + winY), 1.f, color,
luminosity > 0.9f ? shadowColor : brightShadowColor);

Also the text on macOS [retina] is a bit blurry

That's due to the lack of proper support for DPI scaling. There's an incomplete implementation of DPI scaling in the now-abandoned 0.2.x branch (#838, ff3af0f), which has never been merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug some feature is broken help-needed
Projects
None yet
Development

No branches or pull requests

2 participants