Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support threads #58

Open
Phoenix616 opened this issue Jul 27, 2021 · 4 comments
Open

Support threads #58

Phoenix616 opened this issue Jul 27, 2021 · 4 comments
Labels
priority: normal Issue has normal priority for resolution type: feature New feature or request

Comments

@Phoenix616
Copy link
Contributor

Discord is rolling out a new feature called "Threads". Simply forwarding new messages from them (maybe with some thread ID in the message?) should be enough imo.

I assume JDA needs to add support first though :S

@Codixer
Copy link

Codixer commented Jul 28, 2021

JDA is working on this as told in the JDA Discord, but there is no idea how long this will take.

@zachbr zachbr added priority: normal Issue has normal priority for resolution type: feature New feature or request labels Aug 2, 2021
@zachbr
Copy link
Owner

zachbr commented Aug 2, 2021

Thanks - was trying to wrap my head around the best way to deal with this as well. My original thought was just to treat threads similarly to how we handle replies currently. So we'd just include the additional context of the previous message (n-1) with the latest message in that thread (n). A thread ID might work better but I'm not sure.

Honestly, bridging this sort of thing to IRC is never going to be ideal I suspect. If some guild makes a ton of threads under a channel then it also won't scale well. I guess we'll just have to try it and see once JDA adds support.

@Codixer
Copy link

Codixer commented Aug 6, 2021

Yeah, that's going to be a fun story @zachbr. JDA is working on this, but as told in their discord. For this to work, they have to rewrite the plugin to JDA v5 to support all the new features. And moving to discord api v9. So this is going to bring A LOT of deprication problems.

@Phoenix616
Copy link
Contributor Author

Well the JDA v5-threads branch seems to have some recent activity which could enable this and Javacord now also supports it 👀 (but I would hope JDA v5 addresses some of the issues that I see with the overall JDA design which made me choose Javacord instead so I doubt I need to push this project to another library too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Issue has normal priority for resolution type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants