Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Value ("/meta/credentials") for the additional_secret_mount_path is missing in version 1_13 #2779

Open
emrahbecer opened this issue Oct 16, 2024 · 2 comments

Comments

@emrahbecer
Copy link

Please, answer some short questions which should help us to understand your problem / question better?

  • Which image of the operator are you using? e.g spilo-13:2.0-p6
  • Where do you run it - cloud or metal? Kubernetes or OpenShift? [AWS K8s | GCP ... | Bare Metal K8s] -Bare Metal K8S
  • Are you running Postgres Operator in production? [yes | no] both
  • Type of issue? [Bug report, question, feature request, etc.] Probably bug

Hello,

We're trying to upgrade our operator version to 1.13.
In the previous versions there was a default value "additional_secret_mount_path" parameter which we were relying on. I guess most people rely on the default value too.
aws_or_gcp:
type: object
properties:
additional_secret_mount:
type: string
additional_secret_mount_path:
type: string
value: "/meta/credentials

In version 1.13 this default value seems to have been removed :
https://github.com/zalando/postgres-operator/blob/v1.13.0/charts/postgres-operator/crds/operatorconfigurations.yaml#L473

If this change was not done on purpose, perhaps it will be better to put it back for those who rely on the default value. Otherwise the operator fails on pod creation.

For ex:
Warning FailedCreate 10s (x14 over 55s) statefulset-controller create Pod hede-db-cluster-0 in StatefulSet hede-db-cluster failed error: Pod "hede-db-cluster-0" is invalid: [spec.containers[0].volumeMounts[2].mountPath: Required value, spec.containers[1].volumeMounts[1].mountPath: Required value]

Thank you.
Emrah.

@FxKu
Copy link
Member

FxKu commented Nov 26, 2024

hey @emrahbecer
sorry for late reply. I don't recall this ever being a default. I have searched a bit in the history of the CRD but could not find a commit that could have removed it. You're saying the previous release had it?

@emrahbecer
Copy link
Author

No problem. Yes the previous versions had the default value set (/meta/credentials). For example version 1.12 had it. So I guess it was removed beginning with version 1.13.
https://github.com/zalando/postgres-operator/blob/v1.12.0/charts/postgres-operator/crds/operatorconfigurations.yaml#L472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants