Skip to content
This repository has been archived by the owner on Aug 27, 2024. It is now read-only.

Approval Pattern - case insensitive #535

Open
jglapa opened this issue Jun 19, 2018 · 2 comments
Open

Approval Pattern - case insensitive #535

jglapa opened this issue Jun 19, 2018 · 2 comments

Comments

@jglapa
Copy link

jglapa commented Jun 19, 2018

const matcherFn = getAnyMatcherFn(patterns.map(pattern => new RegExp(pattern, 'm')))

Does this mean that the regexp pattern is case sensitive? Could we make that configurable?

@hjacobs
Copy link
Contributor

hjacobs commented Jun 19, 2018

The approval pattern is ":+1:" by default, so case does not matter in that case :smirk:

@jglapa
Copy link
Author

jglapa commented Jun 19, 2018

I know about the default one but I want it to be approved and Approved and APPROVED. Any possibility to do it without ORs in the regexp?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants