-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Migrated] Add Docker Container Image Support #922
Comments
Initially functionality added in #967 |
@alexanderdamiani when you run |
@ArtikUA yes cold starts are slower with docker images. I'm working on a post now to benchmark this for lambda's used for ML deployments. Of course you can use the |
@ian-whitestone I am able to deploy with no issues using docker containers. However, I am not able to deploy with a docker container via GitHub Actions. The issue is referenced in issue #2131 but the issue pertains to zip files and not containers. My current GitHub Action for zappa deployment is: - name: configure aws credentials
uses: aws-actions/configure-aws-credentials@v1
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: ${{ env.AWS_DEFAULT_REGION }}
- name: Deploy dev
run: |
pip install virtualenv
virtualenv my-deploy
source my-deploy/bin/activate
pip install -r requirements.txt zappa
zappa update dev -d ${{ secrets.AWS_ECR_IMAGE_URI }}:latest
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_DEFAULT_REGION: us-east-1 with my traceback:
|
hey @alexanderdamiani , did you try doing this: "and removed the profile_name from the zappa_settings.json" mentioned in Miserlou/Zappa#2131 (comment)? my guess is you have a |
Hi there! Unfortunately, this Issue has not seen any activity for at least 90 days. If the Issue is still relevant to the latest version of Zappa, please comment within the next 10 days if you wish to keep it open. Otherwise, it will be automatically closed. |
Hi there! Unfortunately, this Issue was automatically closed as it had not seen any activity in at least 100 days. If the Issue is still relevant to the latest version of Zappa, please open a new Issue. |
Originally from: Miserlou/Zappa#2188 by ian-whitestone
Earlier this month, AWS announced container image support for AWS Lambda. This means you can now package and deploy lambda functions as container images, instead of using zip files. The container image based approach will solve a lot of headaches caused by the zip file approach, particularly with file sizes (container images can be up to 10GB) and the dependency issues we all know & love.
In an ideal end state, you should be able to call
zappa deploy
/zappa update
/zappa package
(etc.) and specify whether you want to use the traditional zip-based approach or new Docker container based approach. If choosing the latter, Zappa would automatically:For a MVP, we should take a BYOI (bring your own image) approach and just get
zappa deploy
andzappa update
to deploy a lambda function using an existing Docker Image that complies with these guidelines.The text was updated successfully, but these errors were encountered: