Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo setting review #12

Open
joshmoore opened this issue Sep 14, 2020 · 4 comments
Open

Repo setting review #12

joshmoore opened this issue Sep 14, 2020 · 4 comments

Comments

@joshmoore
Copy link
Member

joshmoore commented Sep 14, 2020

The various repository settings concerning merging rules etc. could use a review and/or configuration at the organization level. e.g. see https://github.com/probot/settings#inheritance

@joshmoore
Copy link
Member Author

re: zarr-developers/zarr-python#563 (comment)

After putting the various "decision making" steps together, I should have kicked off a review of the various repository settings. E.g for zarr-python, I'd propose something like this:

Screen Shot 2020-09-14 at 20 17 25

@mzjp2
Copy link
Member

mzjp2 commented Sep 14, 2020

I'd argue against "Dismiss stale pull request approvals" and rely on people's best judgement as to when to re-request a review (and rely on merge permissions as well). It's super annoying to push a tiny typo-fix and needing to wait for someone to re-approve your PR (or annoy them with a ping to re-approve it). Some PR approvals also come with comments (e.g "approved, but please fix typo1 here and typo2 there"), which becomes useless now, because if the comments are addressed then the approval is moot.

@jakirkham
Copy link
Member

No strong feelings from me. This generally sounds reasonable.

Agree with Zain's comment. Just to note another case, we currently require PRs to be up-to-date. So one needs to merge with master before the PR meets that requirement. So this would also cause dismissing stale approvals. Though we could also relax this requirement.

@joshmoore
Copy link
Member Author

I made the two agreed upon changes above to zarr-python. I did not use probot since inheritance didn't work like I had hoped. Let's give that a try and then we can review, discuss here, and rollout further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants