-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump min Python to 3.10 #531
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
==========================================
- Coverage 99.91% 99.91% -0.01%
==========================================
Files 59 59
Lines 2323 2318 -5
==========================================
- Hits 2321 2316 -5
Misses 2 2
|
This would be a good time to ensure numpy 2 support, if it isn't already done. |
There's an issue here: #521; I'm happy to take a look, but don't want to open too many PRs at once 😄 |
It would be great if you could have a look at numpy 2 support. I wonder if we should remove line of code that codecov complains about? https://app.codecov.io/gh/zarr-developers/numcodecs/pull/531/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zarr-developers |
This is good to go - the yellow CI jobs are ones no longer run as they're old versions of Python. I think removing these requires some manual adjustment of repository settings from an admin. |
I removed the requirement for py 3.8 and 3.9. Codecov still needs a bump. |
From one of the builds:
So I think someone needs to set up using a codecov token for codecov to start working again. |
Alright. I added the token. |
* Bump min Python to 3.10 * Bump readthedocs Python * Clean up entrypoints code for Python 3.10+ * Trigger Build
As per SPEC 0 (which it says that zarr is signed up to), drop support from Python 3.8/3.9.