Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert an "Ignored" range prior to the wallet birthday #902

Closed
str4d opened this issue Aug 17, 2023 · 2 comments · Fixed by #903
Closed

Insert an "Ignored" range prior to the wallet birthday #902

str4d opened this issue Aug 17, 2023 · 2 comments · Fixed by #903
Milestone
Spend-before-Sync

Comments

@str4d
Copy link
Contributor

str4d commented Aug 17, 2023 •
edited by nuttycom
Loading

A beta tester of the iOS wallet reported that a brand new wallet appeared to attempt to scan from Sapling activation. This is likely because an "Ignored" range isn't being inserted for SaplingActivation..=WalletBirthday. We should insert this.
@nuttycom nuttycom added this to the Spend-before-Sync milestone Aug 17, 2023
@str4d str4d mentioned this issue Aug 18, 2023
Closed
@str4d
Copy link
Contributor Author

str4d commented Aug 18, 2023

I suspect that doing this would also fix #897.

nuttycom added a commit to nuttycom/librustzcash that referenced this issue Aug 19, 2023
@nuttycom
zcash_client_sqlite: Initialize the scan queue as part of `init_block…
8dc851f 
…s_table`

Fixes zcash#902
Fixes zcash#898
@nuttycom nuttycom mentioned this issue Aug 19, 2023
Merged
@nuttycom nuttycom changed the title Insert a "Scanned" range prior to the wallet birthday Insert an "Ignored" range prior to the wallet birthday Aug 19, 2023
@nuttycom
Copy link
Contributor

I suspect that doing this would also fix #897.

In the case of #897, it's not really a fix because the testnet note commitment tree has less than 2^17 notes in it; any wallet with a birthday below height 490074 will need to scan from Sapling activation, and any wallet with a birthday above that height will need to be scanned from that height (to complete the chain-tip shard) until #901 is complete.

nuttycom added a commit to nuttycom/librustzcash that referenced this issue Aug 21, 2023
@nuttycom
zcash_client_sqlite: Initialize the scan queue as part of `init_block…
b3be031 
…s_table`

Fixes zcash#902
Fixes zcash#898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Spend-before-Sync
Development

Successfully merging a pull request may close this issue.

zcash_client_sqlite: Initialize the scan queue as part of init_blocks_table nuttycom/librustzcash
2 participants
@nuttycom @str4d