Fix V5 transaction txid (#392) #393
Conversation
We will not do this; it could greatly increase the size of |
Verbosity should be a bitfield. |
LarryRuane
force-pushed
the
2022-05-v5-txid
branch
from
804d285
to
85766a0
Compare
|
Force-pushed to address review comments, thanks str4d! |
Perhaps, but we'd need to be careful about how this interacts with upstream, since |
This is a shortcut fix. Instead of replicating the zip244 transaction logic that's implemented in librustzcash: zcash_primitives/src/transaction/components/orchard.rs cheat by calling getblock with verbose level 1, which prints the txid of each transaction. This currently requires calling getblock twice, once for the raw hex (as we have always done), and again to get the transaction IDs. An easy improvement would be to add the raw hex to verbosity 1 result. (Or have a new verbosity that shows both.)
LarryRuane
force-pushed
the
2022-05-v5-txid
branch
from
85766a0
to
07ef9e5
Compare
|
One more force-push to fix a comment as suggested by @str4d |
Partially fixes #392
This is a shortcut fix. Instead of replicating the zip244 transaction
logic that's implemented in librustzcash:
zcash_primitives/src/transaction/components/orchard.rs
cheat by calling getblock with verbose level 1, which prints the txid
of each transaction. This currently requires calling getblock twice,
once for the raw hex (as we have always done), and again to get the
transaction IDs. An easy improvement would be to add the raw hex to
verbosity 1 result. (Or have a new verbosity that shows both.)
The unit tests don't pass with this change, but I wanted to make it
available for testing as soon as possible, we can fix the tests later.