Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to non exisiting http://wiki.oddb.org pages should be corrected #268

Open
ngiger opened this issue Mar 7, 2024 · 3 comments
Open

Comments

@ngiger
Copy link
Collaborator

ngiger commented Mar 7, 2024

When you search for wiki.oddb.org under the src code you get the following hits:

src/view/user/download_export.rb:    link.href = "http://wiki.oddb.org/wiki.php?pagename=ODDB.#{page}"
src/view/drugs/centeredsearchform.rb:                   'http://wiki.oddb.org/wiki.php?pagename=ODDB.Fi-Upload',
src/view/drugs/centeredsearchform.rb:                   'http://wiki.oddb.org/wiki.php?pagename=ODDB.Pi-Upload', 
src/view/datadeclaration.rb:    link.href = 'http://wiki.oddb.org/wiki.php?pagename=Swissmedic.Datendeklaration'
src/view/external_links.rb:                             link.href = "http://wiki.oddb.org/wiki.php?pagename=#{name}"
src/custom/lookandfeelbase.rb:http://wiki.oddb.org/wiki.php/ODDB/Stammdatenmutation
src/custom/lookandfeelbase.rb:http://wiki.oddb.org/wiki.php/ODDB/Fi-Editor
src/custom/lookandfeelbase.rb:http://wiki.oddb.org/wiki.php/ODDB/Fi-Upload
src/custom/lookandfeelbase.rb:http://wiki.oddb.org/wiki.php/ODDB/Pi-Upload
src/custom/lookandfeelbase.rb:        :explain_ddd_price_url    =>  'http://wiki.oddb.org/wiki.php/ODDB/Tageskosten',
src/custom/lookandfeelbase.rb:        :generic_definition_url    =>  'http://wiki.oddb.org/wiki.php/ODDB/WannIstEinMedikamentEinGenerikum',
src/custom/lookandfeelbase.rb:        :explain_ddd_price_url    =>  'http://wiki.oddb.org/wiki.php/ODDB/Tageskosten',
src/custom/lookandfeelbase.rb:        :generic_definition_url   =>  'http://wiki.oddb.org/wiki.php/ODDB/QuandUnMedicamentEst-ilUnGenerique',
src/custom/lookandfeelbase.rb:        :explain_ddd_price_url    =>  'http://wiki.oddb.org/wiki.php/ODDB/Tageskosten',

These links should work. And all links should use https and not http for modern browsers.

@zdavatz
Copy link
Owner

zdavatz commented Mar 7, 2024

wiki.oddb.org no longer exists.

@ngiger
Copy link
Collaborator Author

ngiger commented Mar 7, 2024

Then this links should point to another URL with a meaningful explanation or removed. But missing links are never good and leave a bad impression for any client

@zdavatz
Copy link
Owner

zdavatz commented Mar 7, 2024

the links can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants