Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep only message about upgrading hardware if retry_interval >= 1000ms #2236

Open
vdelendik opened this issue Aug 17, 2023 · 2 comments
Open

Comments

@vdelendik
Copy link
Contributor

[ERROR] Your retry_interval is too low: 1000 ms! Increase it or upgrade your hardware

if possible, change log level to CRITICAL for this use-case. tbd if we should specify cpu in message

@vdelendik vdelendik changed the title kepp only message about upgrading hardware if retry_interval >= 1000ms keep only message about upgrading hardware if retry_interval >= 1000ms Aug 17, 2023
@akamarouski
Copy link
Contributor

@vdelendik there are no CRITICAL level (error is the max log level). Also retry interval hardcoded now:

    private long getRetryInterval(long timeout) {
        long retryInterval = RETRY_TIME; // RETRY_TIME is the retry interval from configuration
        if (timeout >= 3 && timeout <= 10) {
            retryInterval = 500;
        }
        if (timeout > 10) {
            retryInterval = 1000;
        }
        return retryInterval;
    }
    ```
    Maybe we need to remove this code and allow to change retry interval or allow to override this method?

@vdelendik
Copy link
Contributor Author

@akamarouski, do we really override forcibly to 500ms and 1000ms?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants