-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the SCM class structure to handle GenericWebHook config #5
Comments
Delivered in in: Objectice:
Environment:
Pre-conditions:
Test Scenario 1:
Test scenario 2:
Test scenario 3:(see #40)
Expected Results: Scenario 1 and 2 :
Scenario 3:
|
This was referenced Oct 22, 2020
Tested on develop branch. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In order to configure the generic webhook plugin the following configuration has to be made to the functionality of cloning a pr:
https://github.com/zebrunner/qps-pipeline/blob/be1cc52f5229edab81caca76109050f14e99b5dd/src/com/qaprosoft/jenkins/pipeline/tools/scm/github/GitHub.groovy#L112
For each SCM:
+refs/pull/*:refs/remotes/origin/pr/*
+refs/merge-requests/*:refs/remotes/origin/merge-requests/*
And on the side of the Generic Webhook jenkins plugin, a set of variables needs to be created, this variables will store the JSON path expression to acquire the information of the event being triggered and configure the PullRequestJobFactory and PushJobFactory dsl objects. Depending of the type of scm you are registering, the amount of required args for the job dsl configuration may vary.
For such configuration required, and given the current state of the SCM tools implementation, the SCM functionality needs to be refactored, maybe create a dedicate class for each scm type supported in the infra, and add there the prRefSpec, branchSpecifier and the job dsl variables needed to configure the pull request and push dsl objects.
The text was updated successfully, but these errors were encountered: