diff --git a/crates/project/src/terminals.rs b/crates/project/src/terminals.rs index 60e327bc86d19e..463d747215305b 100644 --- a/crates/project/src/terminals.rs +++ b/crates/project/src/terminals.rs @@ -93,7 +93,7 @@ impl Project { cx: &mut ModelContext, ) -> anyhow::Result> { let path = match &kind { - TerminalKind::Shell(path) => path.as_ref().map(|path| path.clone().into()), + TerminalKind::Shell(path) => path.as_ref().map(Clone::clone), TerminalKind::Task(spawn_task) => { if let Some(cwd) = &spawn_task.cwd { Some(cwd.clone().into()) diff --git a/crates/workspace/src/workspace.rs b/crates/workspace/src/workspace.rs index 640c3f63e9ff0e..16ceb354a2293d 100644 --- a/crates/workspace/src/workspace.rs +++ b/crates/workspace/src/workspace.rs @@ -2091,7 +2091,6 @@ impl Workspace { ); cx.spawn(|this, mut cx| async move { if let Some(paths) = paths.await.log_err().flatten() { - let paths = paths.into_iter().map(|p| p.into()).collect(); let results = this .update(&mut cx, |this, cx| { this.open_paths(paths, OpenVisible::All, None, cx) diff --git a/crates/worktree/src/worktree.rs b/crates/worktree/src/worktree.rs index bf0abf3153e930..42f436537a7e95 100644 --- a/crates/worktree/src/worktree.rs +++ b/crates/worktree/src/worktree.rs @@ -724,13 +724,11 @@ impl Worktree { .await .map(CreatedEntry::Included), None => { - let abs_path = this - .update(&mut cx, |worktree, _| { - worktree - .absolutize(&relative_path) - .with_context(|| format!("absolutizing {relative_path:?}")) - })?? - .into(); + let abs_path = this.update(&mut cx, |worktree, _| { + worktree + .absolutize(&relative_path) + .with_context(|| format!("absolutizing {relative_path:?}")) + })??; Ok(CreatedEntry::Excluded { abs_path }) } }