Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline assist suggested changes difficult to read due to background color #19128

Closed
1 task done
esbeto opened this issue Oct 12, 2024 · 7 comments
Closed
1 task done
Labels
ai Improvement related to Assistant, Copilot, or other AI features assistant AI feedback for Assistant (inline or panel) enhancement [core label] theme Feedback for theme configuration, accessibility, visual issues, etc

Comments

@esbeto
Copy link

esbeto commented Oct 12, 2024

Check for existing issues

  • Completed

Describe the feature

The background color used for the inline assist suggestions is difficult to read in any theme. I tried to look for a way to configure it but couldn't find it.

If applicable, add mockups / screenshots to help present your vision of the feature

inline-assistant.mp4
@esbeto esbeto added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Oct 12, 2024
@JosephTLyons JosephTLyons added theme Feedback for theme configuration, accessibility, visual issues, etc ai Improvement related to Assistant, Copilot, or other AI features assistant AI feedback for Assistant (inline or panel) and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Oct 12, 2024
@thataboy
Copy link
Contributor

thataboy commented Oct 12, 2024

try changing info.background deleted.background and modified.background

@esbeto
Copy link
Author

esbeto commented Oct 12, 2024

@thataboy Hmm... where exactly? I'm looking at: https://zed.dev/docs/configuring-zed#folder-specific-settings, and can't find where.

@thataboy
Copy link
Contributor

@thataboy Hmm... where exactly? I'm looking at: https://zed.dev/docs/configuring-zed#folder-specific-settings, and can't find where.

In your theme. or in your settings.json, you can add it to

  "experimental.theme_overrides": {
     "info.background": "#333366",
},

@a-non-a-mouse
Copy link

a-non-a-mouse commented Oct 14, 2024

Changing those settings doesn't do anything for me. It's always bright blue and impossible to read.

image image

Okay, to be fair it's only impossible to read in about half of the themes. It's just very difficult to read in the rest :)

@a-non-a-mouse
Copy link

a-non-a-mouse commented Oct 14, 2024

Correction -- The change is applied, it's just not applied to the current tab. It seems you either need to open a new tab or reload the workspace for it to pick up the change. I also noticed this for something else, though I forget what. Thanks!

@esbeto
Copy link
Author

esbeto commented Oct 15, 2024

OK, so now that I experimented a little bit I noticed these colors are bad only for that particular theme (VSCode Dark Modern theme). The theme switcher does not update the background colors of the AI suggestions, but once you switch to a different theme you will get appropriate colors for that particular theme.

@danilo-leal
Copy link
Contributor

Closing this issue for now as it seems like it was theme-specific and less of a "native" error. Most themes I have here (the bulk of them being the ones that come by default with Zed) look all right—granted, some are better than others, but nothing inaccessible to read, such as the screenshots.

Screen.Recording.2024-11-07.at.09.26.58.mov

@danilo-leal danilo-leal closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai Improvement related to Assistant, Copilot, or other AI features assistant AI feedback for Assistant (inline or panel) enhancement [core label] theme Feedback for theme configuration, accessibility, visual issues, etc
Projects
None yet
Development

No branches or pull requests

5 participants